Date

19 Oct 2020

Authors

Andy Nash (Unlicensed) Joseph (Pepe) Kelly John Simmons (Deactivated) Andy Dingley Simon Meredith (Unlicensed)

Status

In progress

Summary

On Friday evening we saw Jenkins struggling, and then fell over, subsequently causing loads of other weekend timed jobs to fall over ETL and data related issues. Elasticsearch, RabbitMQ and MongoDB fell over between Friday and Saturday

Impact

No Stage. No Prod. No data syncing in various places

1. bump up the Jenkins RAM to 32Gb (short term ONLY). Add a reminder to revisit this in 1 month / 2 months?

Ops

Done

2. disable integration tests on ESR projects for PR pipeline (they’d still run on merge to master, rather than each PR). These are what fire up the local stack and test containers (hold back on…'if we’re not planning to do any further ESR work once Leeerrroooy leave, we could just disable the integration tests in ESR')
ESR guys not keen at all on this. Risk of breaking the pipeline and blocking anything thereafter. When you need it the most…
2. Code in AWS s3 creds to save firing up local stack. Need to be careful how to set this up. Shared bucket for integration tests across Reval, TISSS as well. With archiving rules deleting everything >5 days old.
See ‘diet’ ticket below - lots of work, but an investment that will have its uses across all products within the TIS porfolio

ESR & friends

To do

3. Close outstanding ESR PRs - how many is ‘critical mass’? But without being blazé about approving PRs. Fix major versions only. Ignore minor versions.

ESR / Sachin

To do

Consider ways to reduce system resources instead?
Discussed with Doris and ESR team last week…

4. Restrict the number of PRs Dependabot opens on each ESR project to 1 (but given they’re microservices, it still might be a big number). Not much of a concern if we do 2. above.
There are dependencies between PRs. So restricting to one might have a chain reaction. No getting round that things like this will need manual intervention.
Restrict to only major version changes. Restricting the number of major dependencies might cause issues. So let’s see how restricting to major versions affects things and decide on further action if needed at that point

AndyD

5. Use Jenkins pipeline rather than node - to make things sequential

disableConcurrentBuilds
Disallow concurrent executions of the Pipeline. Can be useful for preventing simultaneous accesses to shared resources, etc. For example: options { disableConcurrentBuilds() }

AndyD / Pepe

Pipelines not written to take advantage of extra nodes - time investment greater than benefit.

6. Address https://hee-tis.atlassian.net/browse/TISNEW-5613 quickly (removing local stack from the Data exporter process). Needs refining and sub-tasking with ESR and perm team, before ESR disappear.

ESR & perm team

7. The ElasticSearch nightly sync shouldn’t be necessary. Verify that ElasticSearch is being updated properly during the day.

Pepe

1. Jenkins

2. ESR containers taking up all the resource

3. Too many (Dependabot) PRs outstanding, builds, rebasing

4. ESR did not had time to action them because of the launch of new world code

1. what else (double check VMs, Logs, etc)?

Discussion, along with short and longer term actions

What can we do about Dependabot creating and building simultaneously?

Dependabot does run sequentially, but much faster than Jenkins can process things so everything appears concurrent.

We could get Dependabot to add a GitHub label to the PR - add something to the Jenkins file to read the label and mark as “Don’t run”.
But this stops Dependabot being useful.

ESR preoccupied with launching New World, understandably!

Can perm team keep on top of ESR stuff when they leave?

Even when keeping on top of things, will it eventually be too much anyway?
Or is it simply a case of the team not controlling the overall number of open PRs?

Original Jenkins build was never designed to handle this much load - underlying architecture isn’t there for the level of automation we now have. It is designed for a single node, not load-balancing

Is Jenkins the right tool for everything it’s being asked to do? No:

1. bump up the Jenkins RAM to 32Gb (short term ONLY). Add a reminder to revisit this in 1 month / 2 months?

2. disable integration tests on ESR projects for PR pipeline (they’d still run on merge to master, rather than each PR). These are what fire up the local stack and test containers (hold back on…'if we’re not planning to do any further ESR work once Leeerrroooy leave, we could just disable the integration tests in ESR')

3. Close outstanding ESR PRs - how many is ‘critical mass’? But without being blazé about approving PRs

4. Restrict the number of PRs Dependabot opens on each ESR project to 1 (but given they’re microservices, it still might be a big number). Not much of a concern if we do 2. above.

5. The ElasticSearch nightly sync shouldn’t be necessary. Verify that ElasticSearch is being updated properly during the day.

6. move ETLs over to ECS tasks (serverless ‘run container' instructions to AWS - not reliant on our infrastructure).
   This would remove the dependency on Jenkins - so if it went down, the jobs could continue.
   Don’t do scheduled jobs / anything with a timer - use Cron server instead for this stuff.
   Just use Jenkins as a build server (Metabase also runs on Jenkins, but doesn’t use much)

7. ticket up addressing our infrastructure so that the set up ESR have created does run - it’s been done right!

8. get ourselves a dedicated Jenkins server (what size )

9. move to ElasticSearch-aa-S