2019-10-02 I can't save placements
Date |
|
Authors | Joseph (Pepe) Kelly |
Status | In Progress |
Summary | |
Impact | Users can't add or amend placements via. the UI. |
Root Cause(s)
Although there's no toast message, the request to TCS fails with a 500 error.
There is a SQL exception (LOG SNIP TO BE ADDED)
The root cause was determined to be due to how the NPN was being encoded/decoded when querying for overlapping placements.
NPNs with a plus sign (+) were not being encoded correctly, causing the plus sign to be converted to a space in the query parameters. As a result the post could not be found and an error was thrown when trying to find placements for the empty post collection.
Trigger
Attempting to save a placement.
Resolution
Initial resolution is to manually encode the query string on the client side and decode it on the server side.
Further work will be needed to specify the behaviour when a post genuinely cannot be found from the queried NPN (e.g. a message saying that overlap cannot be determined).
Detection
Alerted by users
Action Items
Timeline
- The deploy to prod?
- October 2, 2019 11:15ish - Users report via Teams
- ...
- 2.00 pm - Everything's rosey - user reported that the fix has worked on teams
Slack: https://hee-nhs-tis.slack.com/
Jira issues: https://hee-tis.atlassian.net/issues/?filter=14213