Skip to end of metadata
Go to start of metadata

You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 2 Current »

Date

Authors

Andy Dingley

Status

Documentating

Summary

https://hee-tis.atlassian.net/browse/TIS21-1346

Impact

  • Unable to create new trainee’s in TIS, both stage and production

Non-technical Description

Creation of new trainees was failing due to new validation on the “permit to work” field. If the trainee did not have any “right to work” data then the validation failed and creation of the trainee was blocked.

Trigger

  • Failed attempt to create a new Person record

Detection

  • Reported by member of the team on Slack

  • Admins UI E2E tests started failing at some point prior to this due to the same issue.

Resolution

  • Null checks added to the RightToWork validator

Timeline

  • - 15:29 - Reported by team member on slack

  • - 15:35 - Identified as issue with new validation

  • - 16:11 - Fix released to stage for verification

  • - 16:18 - Fix released to production

Root Cause(s)

  • Exception thrown when creating a Person with no PermitToWork details

  • New PermitToWork validation added to RightToWork validator failed

  • The validator did not properly handle null values of RightToWork

Action Items

Action Items

Owner

n/a

Lessons Learned

  • E2E test failures should be viewed as a reflection of the state of the application and not an outlier.

  • No labels

Slack: https://hee-nhs-tis.slack.com/
Jira issues: https://hee-tis.atlassian.net/issues/?filter=14213