2021-03-18 Not able to create new trainees in TIS
Date | Mar 18, 2021 |
Authors | @Andy Dingley |
Status | Done |
Summary | |
Impact |
|
Non-technical Description
Creation of new trainees was failing due to new validation on the “permit to work” field. If the trainee did not have any “right to work” data then the validation failed and creation of the trainee was blocked.
Trigger
Failed attempt to create a new Person record
Detection
Reported by member of the team on Slack
Admins UI E2E tests started failing at some point prior to this due to the same issue.
Resolution
Null checks added to the RightToWork validator
Timeline
Mar 18, 2021 - 15:29 - Reported by team member on slack
Mar 18, 2021 - 15:35 - Identified as issue with new validation
Mar 18, 2021 - 16:11 - Fix released to stage for verification
Mar 18, 2021 - 16:18 - Fix released to production
Root Cause(s)
Exception thrown when creating a Person with no PermitToWork details
New PermitToWork validation added to RightToWork validator failed
The validator did not properly handle null values of RightToWork
Action Items
Action Items | Owner |
---|---|
n/a |
|
Lessons Learned
E2E test failures should be viewed as a reflection of the state of the application and not an outlier.
Slack: https://hee-nhs-tis.slack.com/
Jira issues: https://hee-tis.atlassian.net/issues/?filter=14213