2022-07-21 Downloaded PDF forms showing incomplete data

Owned by Andy Dingley
Last updated: 26 Jul 2022
1 min read

Date

Jul 21, 2022

Authors

@Andy Dingley

Status

Done

Summary

Free text fields not displayed when viewing submitted Form R Part B in TSS

Impact

TSS users were unable to download correct PDFs (Form R Part B)

Non-technical Description

TSS users are able to download a PDF of their submitted forms, this bug caused specific fields to appear blank instead of showing the available data from the Form R Part B:

  • Section 3: Health Statement

  • Section 6: Compliments

  • Covid Declarations: Education Supervisor Name

  • Covid Declarations: Education Supervisor Email Address

Trigger

  • Change deployed which stopped the value from being displayed

Detection

  • TSS user reported that data was missing from their downloaded PDF

Resolution

  • Bug fix to ensure that the field value is returned when it exists.

Timeline

BST unless otherwise stated

  • Jun 28, 2022 16:05 - Change deployed which stopped the value from being displayed

  • Jul 21, 2022 ??:?? - User reported issue with PDF

  • Jul 21, 2022 17:55 - Team notified on support channel that user was having issues

  • Jul 21, 2022 18:52 - Fix identified, decision to submit the following morning

  • Jul 22, 2022 09:49 - Fix submitted

  • Jul 22, 2022 11:11 - Fix deployed to production

Root Cause(s)

  • Submitted change on 2022-06-28 introduced a bug

    • Issue was missed during code review

    • No automated test existed for this scenario, tests only existed for the unhappy path of an empty field

Action Items

Action Items

Owner

Action Items

Owner

Where possible, break up tickets into more subtasks to make them easier to work on/ review

(team)

An email to all users to make them aware of potential missing Form R Part B PDF data (if download PDF 28/6-22/7) and asking them to download PDF again? (not sure about this action so left owner blank @Nazia AKHTAR )

 

Lessons Learned

  • Make sure both happy and unhappy paths are covered by tests

Slack: https://hee-nhs-tis.slack.com/
Jira issues: https://hee-tis.atlassian.net/issues/?filter=14213