Suspicious Exposed Keys

Branch: fix/removeJwtSecretKeyRelates to the following

https://hee-tis.atlassian.net/browse/TISNEW-5214

https://hee-tis.atlassian.net/browse/TISNEW-5269

2020-08-07 Passwords for our services exposed in our PR's

 

TIS Legacy Repos

Repository Name

Credentials Exposed

Secret Name

Where

Comment

TIS-TCS

Yes

jwtSecretKey

https://github.com/Health-Education-England/TIS-TCS/blob/master/tcs-service/.yo-rc.json

Branch: fix/removeJwtSecretKey

PR raised.

Merged.

TIS-TCS

Yes

azure.accountName,
accountKey,
containerName

https://github.com/Health-Education-England/TIS-TCS/blob/master/tcs-service/src/main/resources/config/application-local.yml

Branch: fix/removeAzureKey

Primary intention is to remove the credentials from the code. However, developers might need those credentials if they want to test the upload function locally. Discussion is done on 23rd Sept 2020.

Merged.

TIS-TCS

Yes

kc.realm,
kc.client.id,
kc.server.url,
kc.username,
kc.password

https://github.com/Health-Education-England/TIS-TCS/blob/master/tcs-service/src/main/resources/config/application-local.yml

Branch: chore/removeKcKey

Updated by Andy.

Merged

TIS-TCS

Yes

jhipster.security.authentication.jwt.secret

https://github.com/Health-Education-England/TIS-TCS/blob/master/tcs-service/src/main/resources/config/application-prod.yml

Branch: fix/removeJwtSecretKey

Merged

TIS-TCS

Yes

jhipster.security.authentication.jwt.secret

https://github.com/Health-Education-England/TIS-TCS/blob/master/tcs-persistence/src/test/resources/config/application.yml

Commented out originally.
Branch: fix/removeJwtSecretKey

PR raised.

Merged.

TIS-TCS

Yes

jhipster.security.authentication.jwt.secret

https://github.com/Health-Education-England/TIS-TCS/blob/master/tcs-service/src/test/resources/config/application.yml

Branch: fix/removeJwtSecretKey

PR raised.

Merged.

TIS-TCS

Yes

azure.accountName,
accountKey,
containerName

https://github.com/Health-Education-England/TIS-TCS/blob/master/tcs-service/src/test/resources/config/application.yml

Added the keys in Jenkins credentials for the pipeline unit test.

Need a team discussion how to run the tests locally. We know how to put the env vars in Jenkinsfile.

Discussion was done on 23rd Sept 2020.

Merged.

Added instruction in Readme file to get the secrets fro Azure Access key before running test

TIS-TCS

Yes

kc.realm,
kc.client.id,
kc.server.url,
kc.username,
kc.password

https://github.com/Health-Education-England/TIS-TCS/blob/master/tcs-service/src/test/resources/config/application.yml

Branch: chore/removeKcKey

Updated by Andy

Merged

TIS-Profile

Yes

jhipster.security.authentication.jwt.secret

https://github.com/Health-Education-England/TIS-PROFILE/blob/master/profile-service/src/main/resources/config/application-prod.yml

Branch: fix/removeJwtSecret

Merged.

TIS-Profile

Yes

jhipster.security.authentication.jwt.secret

https://github.com/Health-Education-England/TIS-profile/blob/master/profile-service/src/test/resources/config/application.yml

Branch: fix/removeJwtSecret

Merged.

TIS-Reference

Yes

jhipster.security.authentication.jwt.secret

https://github.com/Health-Education-England/TIS-reference/blob/master/reference-service/src/main/resources/config/application-prod.yml

Branch:
fix/removeJwtSecret

Merged.

TIS-Reference

Yes

jhipster.security.authentication.jwt.secret

https://github.com/Health-Education-England/TIS-reference/blob/master/reference-service/src/test/resources/config/application.yml

Branch:
fix/removeJwtSecret

Merged.

TIS-USERMANAGEMENT

Yes

kc.realm,
kc.master.realm,
kc.client.id,
kc.server.url,
kc.username,
kc.password,

https://github.com/Health-Education-England/TIS-USERMANAGEMENT/blob/master/src/main/resources/application-local.properties

Branch: fix/removeKcSecret
PR raised.

Merged.

TIS-ADMINS-UI

Yes

login.username,
login.password

https://github.com/Health-Education-England/TIS-ADMINS-UI/blob/master/protractor.conf.js

No required

TIS-ADMINS-UI

Yes

login.username,
login.password

https://github.com/Health-Education-England/TIS-ADMINS-UI/blob/master/smoke.test.conf.js

No required

TIS-ADMINS-UI

Yes

slackSend channel.token

https://github.com/Health-Education-England/TIS-ADMINS-UI/blob/master/Jenkinsfile

Branch: chore/removeSlackToken


Merged.
E2E test result is shown in Slack #noticication-e2e-test-result channel

TIS-ASSESSMENTS

Yes

kc.realm,
kc.master.realm,
kc.client.id,
kc.server.url,
kc.username,
kc.password,

https://github.com/Health-Education-England/TIS-ASSESSMENTS/blob/master/assessments-service/src/main/resources/config/application-local.yml

Branch: fix/removeKcSecret

PR raised.

Merged.

TIS-ASSESSMENTS

Yes

kc.realm,
kc.master.realm,
kc.client.id,
kc.server.url,
kc.username,
kc.password,

https://github.com/Health-Education-England/TIS-ASSESSMENTS/blob/master/assessments-service/src/main/resources/config/application-prod.yml

Discussion was done on 23rd Sept 2020.

Branch: fix/removeKcSecret

Merged.

TIS-ASSESSMENTS

Yes

jhipster.security.authentication.jwt.secret

https://github.com/Health-Education-England/TIS-ASSESSMENTS/blob/master/assessments-service/src/test/resources/config/application.yml

Branch:
fix/removeJwtSecret

PR raised.

Merged.

TIS-ASSESSMENTS

Yes

jhipster.security.authentication.jwt.secret

https://github.com/Health-Education-England/TIS-ASSESSMENTS/blob/master/assessments-service/src/test/resources/config/application-local.yml

Branch:
fix/removeJwtSecret

PR raised.

Merged.

TIS-ASSESSMENTS

Yes

jhipster.security.authentication.jwt.secret

https://github.com/Health-Education-England/TIS-ASSESSMENTS/blob/master/assessments-service/src/main/resources/config/application-prod.yml

Branch:
fix/removeJwtSecret

PR raised.

Merged.

TIS-ASSESSMENTS

Yes

jhipster.security.authentication.jwt.secret

https://github.com/Health-Education-England/TIS-ASSESSMENTS/blob/master/assessments-service/.yo-rc.json

Branch:
fix/removeJwtSecret

PR raised.

Merged.

TIS-GENERIC-UPLOAD

Yes

kc.realm,
kc.master.realm,
kc.client.id,
kc.server.url,
kc.username,
kc.password,

https://github.com/Health-Education-England/TIS-GENERIC-UPLOAD/blob/master/generic-upload-service/src/main/resources/config/application-local.yml

Branch: fix/removeKcSecret

PR raised.

Merged.

TIS-GENERIC-UPLOAD

Yes

azure.accountName,
azure.accountKey,
azure.containerName
azure.servicebus.xxx

https://github.com/Health-Education-England/TIS-GENERIC-UPLOAD/blob/master/generic-upload-service/src/main/resources/config/application-local.yml

Branch: fix/removeAzureKey

PR raised.

Merged.

TISGENERIC-UPLOAD

Yes

jhipster.security.authentication.jwt.secret

https://github.com/Health-Education-England/TIS-GENERIC-UPLOAD/blob/master/generic-upload-service/src/main/resources/config/application-prod.yml

Branch:
fix/removeJwtSecret

PR raised.

Merged.

TISGENERIC-UPLOAD

Yes

jhipster.security.authentication.jwt.secret

https://github.com/Health-Education-England/TIS-GENERIC-UPLOAD/blob/master/generic-upload-service/src/test/resources/config/application.yml

Branch:
fix/removeJwtSecret

PR raised.

Merged.

TISGENERIC-UPLOAD

Yes

azure.accountName,
azure.accountKey,
azure.containerName
azure.servicebus.xxx

https://github.com/Health-Education-England/TIS-GENERIC-UPLOAD/blob/master/generic-upload-service/src/test/resources/config/application-local.yml

Branch: fix/removeAzureKey

PR raised.

Merged.

TISGENERIC-UPLOAD

Yes

jhipster.security.authentication.jwt.secret

https://github.com/Health-Education-England/TIS-GENERIC-UPLOAD/blob/master/generic-upload-service/src/test/resources/config/application-local.yml

Branch:
fix/removeJwtSecret

PR raised.

Merged.

TIS-NDW-ETL

Yes

datasource.tis,
datasource.ndw,
datasource.batch

https://github.com/Health-Education-England/TIS-NDW-ETL/blob/master/src/main/resources/application.yml

Branch: fix/removeDatasourceSecret

TIS-DEVOPS: chore/updateNdwVersion

Checked on 7 Oct 20 after the NDW nightly sync (image number eed9806)

Merged

ESR-ETL

Yes

kc.realm,
kc.client.id,
kc.server.url,
kc.username,
kc.password,

https://github.com/Health-Education-England/TIS-ESR-ETL/blob/master/src/main/resources/application.yml

Branch: chore/removeKcSecret
PR raised.

Update TIS-DEVOPS stage and prod 1.6.3.final

Merged

ESR-ETL

Yes

azure.accountName,
azure.accountKey

https://github.com/Health-Education-England/TIS-ESR-ETL/blob/master/src/main/resources/application.yml

Branch: removeAzureKey

Update TIS-DEVOPS stage and prod 1.6.4.final

Merged.

ESR-ETL

Yes

kc.realm,
kc.client.id,
kc.server.url,
kc.username,
kc.password,

https://github.com/Health-Education-England/TIS-ESR-ETL/blob/master/src/main/resources/application-dev.yml

Branch: chore/removeKcCred

PR raised.

TIS-DEVOPS Branch

update-esr-etl-to-stage-and-prod (merged)

On 6 Oct2020, at 3:30pm we checked in stage and prod the version of the etl is 1.6.1.final
Merged.

ESR-ETL

Yes

azure.accountName,
azure.accountKey

https://github.com/Health-Education-England/TIS-ESR-ETL/blob/master/src/main/resources/application-dev.yml

Branch: chore/removeAzureKey

PR raised and merged with master

Update TIS-DEVOPS stage and prod 1.6.2.final

Merged

ESR-ETL

Yes

kc.realm,
kc.client.id,
kc.server.url,
kc.username,
kc.password,

https://github.com/Health-Education-England/TIS-ESR-ETL/blob/master/src/main/resources/application-local.yml

Branch: chore/removeKcCred

PR raised.

TIS-DEVOPS Branch

update-esr-etl-to-stage-and-prod (merged)

On 6 Oct2020, at 3:30pm we checked in stage and prod the version of the etl is 1.6.1.final
Merged.

ESR-ETL

Yes

azure.accountName,
azure.accountKey

https://github.com/Health-Education-England/TIS-ESR-ETL/blob/master/src/main/resources/application-local.yml

Branch: chore/removeAzureKey

PR raised and merged with master

Update TIS-DEVOPS stage and prod 1.6.2.final

Merged.

ESR-ETL

Yes

kc.realm,
kc.client.id,
kc.server.url,
kc.username,
kc.password,

https://github.com/Health-Education-England/TIS-ESR-ETL/blob/master/src/main/resources/application-prod.yml

Branch: chore/removeKcSecret

PR raised.

Update TIS-DEVOPS stage and prod 1.6.3.final

Merged.

ESR-ETL

Yes

azure.accountName,
azure.accountKey

https://github.com/Health-Education-England/TIS-ESR-ETL/blob/master/src/main/resources/application-prod.yml

Branch: removeAzureKey

Update TIS-DEVOPS stage and prod 1.6.4.final

Merged.

ESR

Yes

kc.realm,
kc.master.realm,
kc.client.id,
kc.server.url,
kc.username,
kc.password,

https://github.com/Health-Education-England/TIS-ESR/blob/master/esr-service/src/main/resources/config/application-dev.yml

Branch: chore/removeKcCredentials

chore/removeKcUrl

PR Raised

TIS-DEVOPS

Branch: push-esr-change-to-stage-and-prod

Merged

ESR

Yes

kc.realm,
kc.master.realm,
kc.client.id,
kc.server.url,
kc.username,
kc.password,

https://github.com/Health-Education-England/TIS-ESR/blob/master/esr-service/src/main/resources/config/application-local.yml

Branch: chore/removeKcCredentials

PR Raised

TIS-DEVOPS

Branch: push-esr-change-to-stage-and-prod

Merged

ESR

Yes

jhipster.security.authentication.jwt.secret

https://github.com/Health-Education-England/TIS-ESR/blob/master/esr-service/src/main/resources/config/application-prod.yml

Branch: removeJWTSecret

https://github.com/Health-Education-England/TIS-DEVOPS/pull/980

Merged

ESR

Yes

kc.realm,
kc.master.realm,
kc.client.id,
kc.server.url,
kc.username,
kc.password,

https://github.com/Health-Education-England/TIS-ESR/blob/master/esr-service/src/test/resources/config/application-test.yml

Branch: chore/removeKcSecret

Merged.

Changed the DEVOPS for the version number

Merged

TIS-REVALIDATION

Yes

security.user.password

https://github.com/Health-Education-England/TIS-REVALIDATION/blob/master/src/main/resources/application.properties

Branch: fix/removeSecurityUserPassword

Merged.

TIS-SHARED-MODULE

No

 

 

 

TIS-GMC-SYNC

Yes

gmc.username,
gmc.password

https://github.com/Health-Education-England/TIS-GMC-SYNC/blob/master/src/main/resources/application.properties

Branch: chore/removeGmcSecret

Merged.

TIS-GMC-SYNC

Yes

kc.realm,
kc.client.id,
kc.server.url,
kc.username,
kc.password,

https://github.com/Health-Education-England/TIS-GMC-SYNC/blob/master/src/main/resources/application.properties

Branch: chore/removeKcSecret

Branch for fixing pipeline: chore/fixJenkins

Merged.

TIS-INTREPID-REVAL-ETL

Yes

kc.realm,
kc.client.id,
kc.server.url,
kc.username,
kc.password,

https://github.com/Health-Education-England/TIS-INTREPID-REVAL-ETL/blob/master/src/main/resources/application.properties

Branch Name:

chore/removeKcCreds

PR Raised and merged with master

  1. checked the jenkins pipeline from where we should get the 1.4.27 build version

  2. Updated TIS-DEVOPS repo platform.yml

  3. Checked in HEE-TIS-VM-PROD-APPS-BLUE the 1.4.27 version is there

Merged

TIS-INTREPID-REVAL-ETL

Yes

kc.realm,
kc.client.id,
kc.server.url,
kc.username,
kc.password,

https://github.com/Health-Education-England/TIS-INTREPID-REVAL-ETL/blob/master/src/test/resources/application.properties

Branch Name:

chore/removeKcCreds

PR Raised and merged with master

  1. check the jenkins pipeline from where we should get the 1.4.27 build version

  2. Update TIS-DEVOPS repo platform.yml

  3. Checked in HEE-TIS-VM-PROD-APPS-BLUE the 1.4.27 version is there

Merged

TIS-CONCERNS

Yes

azure.accountName,
azure.accountKey

https://github.com/Health-Education-England/TIS-CONCERNS/blob/master/src/main/resources/application-local.properties

Branch: fix/removeAzureKey

Merged.

TIS-CONCERNS

Yes

azure.accountName,
azure.accountKey

https://github.com/Health-Education-England/TIS-CONCERNS/blob/master/src/test/resources/application-test.properties

Branch: fix/removeAzureKey

Merged.

TIS-CONNECTION-DISCREPANCIE

No

 

 

 

TIS-NOTIFICATIONS

No

 

 

 

TIS-SYNC

Yes

kc.server.url,
kc.username,
kc.password,

https://github.com/Health-Education-England/TIS-SYNC/blob/master/src/main/resources/config/application-local.yml

Branch: chore-remove-exposed-creds

Merged.

Checked in dev-monitoring channel after nightly sync

TIS-SYNC

Yes

kc.server.url,
kc.username,
kc.password,

https://github.com/Health-Education-England/TIS-SYNC/blob/master/src/test/resources/config/application.yml

Branch: chore-remove-exposed-creds

Merged.

Checked in dev-monitoring channel after nightly sync

TIS-SYNC

Yes

azure.accountName,
azure.accountKey

https://github.com/Health-Education-England/TIS-SYNC/blob/master/src/main/resources/config/application-local.yml

Branch: chore-remove-exposed-creds

Merged.

Checked in dev-monitoring channel after nightly sync

TIS-SYNC

Yes

azure.accountName,
azure.accountKey

https://github.com/Health-Education-England/TIS-SYNC/blob/master/src/test/resources/config/application.yml

Branch: chore-remove-exposed-creds

Merged.

Checked in dev-monitoring channel after nightly sync

TIS-SYNC

Yes

jhipster.security.authentication.jwt.secret

https://github.com/Health-Education-England/TIS-SYNC/blob/master/src/main/resources/config/application-prod.yml

Branch: chore-remove-exposed-creds

Merged.

Checked in dev-monitoring channel after nightly sync

TIS-SYNC

Yes

jhipster.security.authentication.jwt.secret

https://github.com/Health-Education-England/TIS-SYNC/blob/master/src/test/resources/config/application.yml

Branch: chore-remove-exposed-creds

Merged.

Checked in dev-monitoring channel after nightly sync

 

ESR Bi-Di

Repository Name

Credentials Exposed

Secret Name

Where

Comment

TIS-EsrReconciliationService

Yes

userRemoteConfigs.credentialsId

https://github.com/Health-Education-England/TIS-EsrReconciliationService/blob/master/Jenkinsfile

NO NEED TO CHANGE

TIS-EsrMockData

Yes

userRemoteConfigs.credentialsId

https://github.com/Health-Education-England/TIS-EsrMockData/blob/master/Jenkinsfile

NO NEED TO CHANGE

TIS-EsrAuditService

Yes

userRemoteConfigs.credentialsId

https://github.com/Health-Education-England/TIS-EsrAuditService/blob/master/Jenkinsfile

NO NEED TO CHANGE

TIS-EsrTheGreatMigrate

Yes

userRemoteConfigs.credentialsId

https://github.com/Health-Education-England/TIS-EsrTheGreatMigrate/blob/master/Jenkinsfile

NO NEED TO CHANGE

TIS-EsrDataExportService

Yes

aws.access.key.id,
aws.secret.access.key

https://github.com/Health-Education-England/TIS-EsrDataExportService/blob/master/src/main/resources/application-local.yml

Branch: chore/removeAwsAccessKey

PR raised

Merged

TIS-EsrDataExportService

Yes

aws.access.key.id,
aws.secret.access.key

https://github.com/Health-Education-England/TIS-EsrDataExportService/blob/master/src/test/resources/application-int.yml

NO NEED TO CHANGE

TIS-EsrDataExportService

Yes

userRemoteConfigs.credentialsId

https://github.com/Health-Education-England/TIS-EsrDataExportService/blob/master/Jenkinsfile

NO NEED TO CHANGE

TIS-EsrNotificationGeneratorService

Yes

userRemoteConfigs.credentialsId

https://github.com/Health-Education-England/TIS-EsrNotificationGeneratorService/blob/master/Jenkinsfile

NO NEED TO CHANGE

TIS-EsrInboundDataReaderService

Yes

azure.accountName,
azure.accountKey

https://github.com/Health-Education-England/TIS-EsrInboundDataReaderService/blob/master/src/main/resources/application-local.yml

Branch: chore/removeAzureKey

Merged.

TIS-EsrInboundDataReaderService

Yes

aws.accessKeyId,
aws.secretKey

https://github.com/Health-Education-England/TIS-EsrInboundDataReaderService/blob/master/src/main/resources/application-local.yml

Branch: chore/removeAwsSecret

Merged

TIS-EsrInboundDataReaderService

Yes

azure.accountName,
azure.accountKey

https://github.com/Health-Education-England/TIS-EsrInboundDataReaderService/blob/master/src/test/resources/application-int.yml

Branch: chore/removeAzureKey

Merged.

TIS-EsrInboundDataReaderService

Yes

userRemoteConfigs.credentialsId

https://github.com/Health-Education-England/TIS-EsrInboundDataReaderService/blob/master/Jenkinsfile

NO NEED TO CHANGE

TIS-EsrInboundDataWriterService

Yes

userRemoteConfigs.credentialsId

https://github.com/Health-Education-England/TIS-EsrInboundDataWriterService/blob/master/Jenkinsfile

NO NEED TO CHANGE

 

TIS Self Service

snipRepository Name

Credentials Exposed

Secret Name

Where

tis-trainee-details

No

 

 

tis-trainee-forms

No

 

 

tis-trainee-sync

No

 

 

tis-trainee-reference

No

 

 

trainee-ui

No

 

 

 

Revalidation (New)

Repository Name

Credentials Exposed

Secret Name

Where

Comment

tis-revaliation-core

No

 

 

 

tis-revaliation-integration

No

 

 

 

tis-revalidation-integration

Yes

kc.realm,
kc.client.id,
kc.server.url,
kc.username,
kc.password,

https://github.com/Health-Education-England/tis-revalidation-integration/blob/master/src/main/resources/application.yml

Branch: fix/removeKcSecret

PR raised.

Merged.

TIS-REVALIDATION-V2

Yes

userPoolId,
userPoolWebClientId

https://github.com/Health-Education-England/TIS-REVALIDATION-V2/blob/master/src/environments/constants.ts

NO NEED TO CHANGE,

As this is a FE repo, these credentials will be exposed to the public anyway.

tis-revalidation-concerns

No

 

 

 

TIS-GMC-client

No

 

 

 

tis-common-upload

No

 

 

 

TCS-reval-mock

No

 

 

 

REVALIDATION-COMBINE

No

 

 

 

GMC-CONNECT-MOCK

No

 

 

 

TIS-HEE-REVALIDATION

No

 

 

 

tis-revalidation-connection

No