Sprint 51 Review (2018-06-27)

Owned by Andy Nash (Unlicensed)
Last updated: 28 Jun 2018 by Suneet Kamath (Unlicensed)
6 min read

Availability

(assume Team Availability Calendar is up to date, otherwise, everyone is available for 9 days):

Joanne

Ify

Ola

Panos

Chris

Suneet

-3.5

-1

-3

-7

-4

-7


Sprint Priorities

The following list was the prioritisation output from Sprint Planning - largely a stabilisation Sprint:

  1. BAU - POs to review what are P1s in Jira as a matter of urgency. To include:
    1. Rotations ID being saved rather than Rotation name / Make Rotation name a read only field
    2. One London office can't create posts (Chris / John G and Sunil) TISDEV-4854 
  2. Technical debt +
    1. 15 votes: Increase team knowledge of TIS big picture
    2. 14 votes: Testing so we can release with confidence
    3. 12 votes: Pipeline replacement
    4. 12 votes: E2E test coverage (ESR)
    5. 11 votes: Filming the team – this is who we are!
    6. 10 votes: Integration tests
    7. 9 votes: Clearly define a domain model – a clear representation of what TIS is
    8. Replacing jHipster front end code
    9. TIS NDW mappings
  3. Knowledge transfer
    1. Confluence housekeeping - especially deleting documentation that is out of date
    2. Coding standards (Dev meeting / series of meetings)
    3. Pairing / Mobbing
    4. Git-commit messages
    5. Walk-throughs (prep as you go). 
    6. Architectural level diagrams (this is a GROUP activity not a lonely boring task)
  4. Development (P1s - POs to review what are P1s in Jira as a matter of urgency)
    1. Assessments – continuing work (Paul)
    2. Placement comments - P1s in Next Up (Suneet)
    3. Removal of deleted records (Alice confirmed)
    4. NDW UAT feedback analysis – Product team (support needed once HiCom turn on the TIS-Intrepid ETL to switch on their modules - Friday?)
    5. Discovery/research – replacements for HICOM modules (CPPS, Placement Manager, Leave Manager, CBMS) and trust and trainee portal - Product team (Rob to confirm priorities within this)
    6. Sub-specialty (fixed on dev - check just waiting for release - Ola)
    7. Mapping metadata from the document management import (Luis)
    8. People / Posts paramatised - TISDEV-4926 (1 day Spike) / TISDEV-4927 (long term solution to Paul's prototype) / WAF / Analysis around sanitiser
    9. ESR (DevOps) needs refactoring (Fred)
    10. DR planning - incl. geo-replication, roll back and build again scenarios (John S and Ops)


Contents

The following items to be shared by team members during this sprint review


Item

Owner

Description of work

Link. e.g. to working software
https://apps.tis.nhs.uk/
(note: use Dev for
obfuscated data)		Loom video of completed work
https://www.useloom.com/

Production Application releases / updates


Simon Meredith (Unlicensed)

Oladimeji Onalaja (Unlicensed)

Jayanta Saha

(and anyone else involved)

Releases

  • TIS-49  -  Includes upgrade of Admins-UI to Angular 5
  • Inbound ETL retired
    • TIS becomes sole 'owner' of core Trainee Data
    • Hicom now take read only copy overnight
    • TIS External Data Flows are much simpler




https://build.tis.nhs.uk/jenkins/view/Prod/job/intrepid-etl-pipeline-new/


BAU (incl. Rotations ID being saved rather than Rotation name / Make Rotation name a read only field,
and One London office can't create posts TISDEV-4854 (Chris / John G and Sunil))
  • Qualification dates pulling through incorrectly

  • Spike converting Post/People Search endpoints to use prepared statements

  • TIS does not allow for searching on posts with a + or brackets

  • TIS does not seem to allow searching on site names with an apostrophe

  • Orphaned Placements on Production



Technical debt +

  1. 15 votes: Increase team knowledge of TIS big picture
  2. 14 votes: Testing so we can release with confidence (incl. E2E tests - ESR and Integration tests)
  3. 12 votes: Pipeline replacement
  4. 11 votes: Filming the team – this is who we are!
  5. 9 votes: Clearly define a domain model – a clear representation of what TIS is
  6. Replacing jHipster front end code
  7. TIS NDW mappings

Paul


Shivani

  • started to increase the test coverage of the Assessment service

TIS Testing:

  • Analysed and identified gaps in existing testing.
  • Analysed the existing type of testing and drafted the strategy to fill/introduce gaps in current Pipeline.
    https://hee-tis.atlassian.net/wiki/spaces/TISDEV/pages/591757371
  • Aligned with DevOps team to introduce E2E in CI pipeline.
    Provided demo for proposed future testing strategy across components to Andy and Simon.
  • Supported various release activities by providing required test feedback.
    Raised defects for No Key, specialities and curriculum components.
  • KT session with Jag and Team for ESR integration.
  • Discussion with Jag for ESR integration and component testing.
  • Fixed E2E tests across admin UI including components People, Post, Curriculum, Speciality, Assessments failed due to UI changes, element locator Id changes and UI staling and spinning Work in Progress for some tests related to timeout and other changes.


Knowledge transfer

  1. Confluence housekeeping - especially deleting documentation that is out of date
  2. Coding standards (Dev meeting / series of meetings)
  3. Pairing / Mobbing
  4. Git-commit messages
  5. Walk-throughs (prep as you go). 
  6. Architectural level diagrams (this is a GROUP activity not a lonely boring task)


  1. Former user (Deleted) / Ruth Orhiunu (Unlicensed) / All Dev team
  2. All Dev team
  3. All Dev team
  4. All Dev team
  5. All Dev team
  6. Reuben Noot (Deactivated) / All Dev team
  7. Frederic Randriamora (Unlicensed)

Paul

  • Knowledge transfer session on the Assessment service, history, complications, reasons and design choices
  • TISConf!

Jag

  • Knowledge transfer sessions for ESR for the team.
  • Documented additional technical/Dev level details on the project.

Jayanta (KR)

  • Identified the potential KT areas such as NDW ETL, Document Management, ESR, Bulk upload etc.for collecting knowledge.
  • On going KR is going on NDW ETL, ESR, Assessment , Bulk upload and Big picture of TIS.  
  • Organising the KT sessions with the respective KD and the permanent team members.
  • Documenting knowledge so that team members can act on it when necessary.
  • Bulk upload ticket on Placement ID as matching criteria.

Reuben

Frederic:

  • continued on documenting backup / restore
  • focused on multi-region backup

Suneet : 

  • Knowledge transfer of Generic Uploads for bulk-people upload (Jayanta/Hamed)

Assessments Application











NDW ETL  Setup
















/wiki/spaces/TISDEV/pages/539525127




Jag:

https://github.com/Health-Education-England/TIS-ESR-ETL

Ashley:

ESR-ETL Timings:

ETL Timings















Development (P1s - POs to review what are P1s in Jira as a matter of urgency)

  1. Assessments – continuing work
  2. Placement comments - P1s in Next Up
  3. Removal of deleted records (Alice confirmed)
  4. NDW UAT feedback analysis – Product team (support needed once HiCom turn on the TIS-Intrepid ETL to switch on their modules - Friday?)
  5. Discovery/research – replacements for HICOM modules (CPPS, Placement Manager, Leave Manager, CBMS) and trust and trainee portal - Product team (Rob to confirm priorities within this)
  6. Sub-specialty (fixed on dev - check just waiting for release)
  7. Mapping metadata from the document management import
  8. People / Posts paramatised - TISDEV-4926 (1 day Spike) / TISDEV-4927 (long term solution to Paul's prototype) / WAF / Analysis around sanitiser
  9. ESR (DevOps) needs refactoring
  10. DR planning - incl. geo-replication, roll back and build again scenarios


  1. Paul Hoang (Unlicensed)
  2. Suneet Kamath (Unlicensed)
  3. TBC
  4. PO Group
  5. PO Group
  6. Oladimeji Onalaja (Unlicensed)
  7. Luís Matos (Unlicensed) / Panos Paralakis (Unlicensed)
  8. Paul Hoang (Unlicensed)
  9. Frederic Randriamora (Unlicensed) / Former user (Deleted) / Ashley Ransoo
  10. John Simmons (Deactivated) / Frederic Randriamora (Unlicensed) / Chris Mills (Unlicensed)

Paul

  • With the Reasons ETL complete for Assessment Outcome Reasons, worked with Fred to run it on DEV - waiting the required changes on the FE to release at the same time
  • Added support to the Assessments service to allow for the deletion of assessments and all relating entities (Pre/Post assessment - reasons etc - currently backend only)

Ola

  •  Assessments - Pre assessment details logic updated in FE to retrieve CurriculumSpecialty and CurriculumSubType data for records that currently have it missing
  •  Post - Updated FE logic to ensure the rendering of Funding body name
  •  Placements - Tested applied fix for Sub-specialty field issue on Stage with Joanne Watson (Unlicensed), fix pushed  to Prod after success

9. Jag/Fred

  • Migration of crontab FTP Sync job to Jenkins job has been tested. The cron job is flexible handling only the required files and factoring the time. MTP pending.
  • An additional manual FTP sync Jenkins job has been created giving the flexibility of filtering by individual local office and file types.

Jag: 

Looked in to some issues raised by ESR.

  • National Insurance rollout and format issue.
  • Site known as instead of VPD code.
  • Hicom backlog files processing.
  • LOV mismatch warning. (TISDEV-5001)
  • few other bau issues

John S:

  • Retired consolidated & intrepid ETL's
  • Compressed the start times of the existing ETL's
  • Blocked the ability of intrepid ETL to be manually run accidentally
  • Uploaded final intrepid snapshot to azure cold storage
  • Test recover of the MS-SQL backup to make sure it was usable
  • service pipeline replacement sketch
  • Pipeline proof of concept (WIP - with Frederic Randriamora (Unlicensed))

Suneet :

  • @doing Bulk upload template with ids TIS-4441 Analysis (with AR) and Pairing (with JS)
    • might need to pick this up myself as pace not going as well as envisioned
  • @nextUp PR Rotations fixes for generic uploads
  • @done Fixed 60+ Critcal issues/Bugs reported by sonar (more regression testing needed - perhaps a sign-off by Ashley Ransoo); code coverage dependant on dead code which needs to be cleaned up and needs attention after; most Major/Minor issues tied to dead code
  • @waiting PR 24 for Shared Modules 
  • Comments on Placement Bulk Uploads (evolving)
    • @doing now supports source of Comments (Bulk uploads/Intrepid) and Author
    • @todo re-import comments from Intrepid mirror
    • @done Admin-UI PR approval to display read-only comments (before bulk-upload of Intrepid data)
    • @todo deployments of ADMIN-UI and GENERIC_UPLOAD services

https://www.useloom.com/share/30b62ba412464620a69c1623d70f72fd






9. Jag/Fred

https://build.tis.nhs.uk/jenkins/job/tis-esr-ftpsync-cron-stage/

https://build.tis.nhs.uk/jenkins/job/tis-esr-ftpsync-manual/


Resource Planning

Reuben Noot (Deactivated)

Andy Nash (Unlicensed)

Agency update

Advert gone out for two BA roles (London-based) to give us a head-start on recruiting TIS Team #2, which will be an outside of London-based team.

Full Time recruitment

No joy with the final FED role as yet.

Other

Ruth left us (sad)





Slack: https://hee-nhs-tis.slack.com/
Jira issues: https://hee-tis.atlassian.net/issues/?filter=14213